Add "game" option to File#59
Closed
HeroponRikiBestest wants to merge 1 commit intoClementJ18:developfrom
HeroponRikiBestest:File-game-name
Closed
Add "game" option to File#59HeroponRikiBestest wants to merge 1 commit intoClementJ18:developfrom HeroponRikiBestest:File-game-name
HeroponRikiBestest wants to merge 1 commit intoClementJ18:developfrom
HeroponRikiBestest:File-game-name
Conversation
Add "game" option to File that holds game name, should the file be attached to a game
Owner
|
Thanks for the PR, this is a nice addition although I will probably go with a more generic implementation #60 |
Author
|
Sounds good; I'm not very familiar with the potential locations, or this codebase, so I appreciate the more generic implementation. Thanks for adding this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add "game" option to File that holds game name, should the file be attached to a game.